search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.28k stars 505 forks source link

Livingwood/Dreamwood Planks have the wrong noteblock sound (Harp instead of bass) #4564

Closed UmbralSurvivor closed 7 months ago

UmbralSurvivor commented 8 months ago

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

1.20.1-443-FABRIC

Modloader version

Fabric 0.15.3

Modpack info

No response

The latest.log file

https://pastebin.com/7J82WaPS

Issue description

Botania wooden planks have the wrong noteblock sound.

Steps to reproduce

Place a vanilla plank and a botania plank next to each other. Place a noteblock on top of each. Note (Via F3 or right-clicking) that the noteblock instruments are different, (Bass for vanilla, harp for Botania)

Other information

This also breaks compatibility with the new "Sawmill" mod's auto recipe generation.

dhouck commented 7 months ago

This also causes compat issues with other mods; see MehVahdJukaar/WoodGood#439. Although I’m not sure why they can’t just use the #minecraft:planks tag…

TheRealWormbo commented 7 months ago

Same actually applies to livingrock blocks. They should probably make basedrum sounds, but also just play harp. It might be worth checking all Botania blocks for their noteblock instruments.