search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.25k stars 497 forks source link

Damage type datagen fix #4683

Closed BrokenK3yboard closed 2 weeks ago

BrokenK3yboard commented 2 weeks ago

Fix datagen for damage types, manually writing entries should no longer be necessary.

BrokenK3yboard commented 2 weeks ago

It's extended from FabricDynamicRegistryProvider and is meant to register multiple different types. Enchantments and Enchantment providers need to be registered there as well for them to be generated (At least in 1.21) among other things, so I don't have any clear-cut name in mind.

TheRealWormbo commented 2 weeks ago

It's just that the class name itself says even less about what it's supposed to do than its parent class. So as far as I understand, it fills dynamic registries with data relevant to Botania's datagen run. How about BotaniaDynamicRegistryProvider, then?

BrokenK3yboard commented 2 weeks ago

Sounds fine to me.