VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.27k stars 505 forks source link

Some overworld structures fail to generate in Garden of Glass #4712

Closed TheRealWormbo closed 2 months ago

TheRealWormbo commented 2 months ago

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

444

Modloader version

(any)

Modpack info

No response

The latest.log file

(n/a)

Issue description

Certain types of overworld structures cannot be found via /locate structure in a Garden of Glass world. Others can be found but at rather unusual heights, typically the bottom of the world.

Examples of structures not found via /locate structure, even when executing near a potential location (according to ChunkBase):

Examples of structures that do generate (without any blocks, as expected), but starting below the bottom of the world:

Steps to reproduce

  1. Set up a Fabric instance with Botania (plus dependencies) and MiniHud (plus MaLiLib)
  2. Create a new GoG world with creative mode and commands enabled.
  3. Use /locate structure minecraft:jungle_pyramid — the command will take a while to run, but eventually report failure.
  4. Use /locate structure #minecraft:village — the command will usually complete relatively quickly.
  5. Teleport to the village.
  6. Enable MiniHud structure bounding box rendering for villages (H+C -> Structures; ensure "mainRenderingToggle", "overlayStructureMainToggle", and "Village" are enabled) and chunk borders (F3+G) — the village bounding box is rendered likely starting below the chunk border overlay.

Other information

Depth-dependent world features (e.g. Deep Dark, ancient cities, and cave biomes) still generate where they are to be expected. It would only make sense that villages generate where the surface would be, potentially even following the non-GoG terrain shape.