search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.28k stars 510 forks source link

Mystical Flower spawning rules not respected. #4760

Open neinome opened 1 month ago

neinome commented 1 month ago

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-446

Modloader version

47.3.7

Modpack info

No response

The latest.log file

https://pastebin.com/BYgrbntA

Issue description

During world generation, mystical flowers spawn in the Minecraft overworld, despite the only allowed biomes being in the Twilight Forest. This was set up using KubeJS datapacks. This works flawlessly with single player and all other KubeJS datapack modifications also work properly.

Steps to reproduce

  1. Set up dedicated server with Twilight Forest and KubeJS modifying data/botania/tags/worldgen/biome/mystical_flower_blocklist.json and data/botania/tags/worldgen/biome/mystical_flower_spawnlist.json such that the only place that flowers should spawn is the Twilight Forest
  2. Generate world
  3. Mystical Flowers will be in the overworld

Other information

No response

neinome commented 1 month ago

OK, further experimentation shows that the client is also affected, though this seed: -7117881137917149671 seems to house the rare occurrence of this, having a patch of Black Mystical Flowers near world spawn, that seems to be extremely random about how/if it spawns. About 350 blocks south the Black patch is a patch of Red Mystical Flowers that is rather uniform in composition.

Oddly, these two patches seem to be the only instances of the Mystical Flowers even on this seed. Other seeds I've tried made me think that there were no issues, but here we are.... image image

neinome commented 1 month ago

Here are my edits to the spawning files: botania/tags/worldgen/biome/mystical_flower_blocklist.json: { "replace": true, "values": [ { "id": "#forge:is_overworld", "required": true } ] }

botania/tags/worldgen/biome/mystical_flower_spawnlist.json: { "replace": true, "values": [ "twilightforest:clearing", "twilightforest:dark_forest", "twilightforest:dark_forest_center", "twilightforest:dense_forest", "twilightforest:enchanted_forest", "twilightforest:fire_swamp", "twilightforest:firefly_forest", "twilightforest:forest", "twilightforest:highlands", "twilightforest:lake", "twilightforest:oak_savannah", "twilightforest:snowy_forest", "twilightforest:spooky_forest", "twilightforest:stream", "twilightforest:swamp" ] }

neinome commented 3 weeks ago

I've now tried specifying the exact biomes I want to block/have mystical flowers spawn in.... and still the results are the same: botania/tags/worldgen/biome/mystical_flower_blocklist.json: { "replace": true, "values": [ "aether:skyroot_forest", "aether:skyroot_grove", "aether:skyroot_meadow", "aether:skyroot_woodland", "aether_redux:cloudcaps", "aether_redux:frosted_forests", "aether_redux:gilded_grasslands", "aether_redux:gilded_groves", "aether_redux:glacial_tundra", "aether_redux:skyfields", "aether_redux:skyroot_shrublands", "aether_redux:the_blight", "ars_elemental:blazing_forest", "ars_elemental:cascading_forest", "ars_elemental:flashing_forest", "ars_elemental:flourishing_forest", "ars_nouveau:archwood_forest", "biomesoplenty:auroral_garden", "biomesoplenty:bayou", "biomesoplenty:bog", "biomesoplenty:clover_patch", "biomesoplenty:cold_desert", "biomesoplenty:coniferous_forest", "biomesoplenty:crag", "biomesoplenty:crystalline_chasm", "biomesoplenty:dead_forest", "biomesoplenty:dryland", "biomesoplenty:dune_beach", "biomesoplenty:erupting_inferno", "biomesoplenty:field", "biomesoplenty:fir_clearing", "biomesoplenty:floodplain", "biomesoplenty:forested_field", "biomesoplenty:fungal_jungle", "biomesoplenty:glowing_grotto", "biomesoplenty:grassland", "biomesoplenty:highland", "biomesoplenty:jade_cliffs", "biomesoplenty:lavender_field", "biomesoplenty:lavender_forest", "biomesoplenty:lush_desert", "biomesoplenty:lush_savanna", "biomesoplenty:maple_woods", "biomesoplenty:marsh", "biomesoplenty:mediterranean_forest", "biomesoplenty:moor", "biomesoplenty:muskeg", "biomesoplenty:mystic_grove", "biomesoplenty:old_growth_dead_forest", "biomesoplenty:old_growth_woodland", "biomesoplenty:ominous_woods", "biomesoplenty:orchard", "biomesoplenty:origin_valley", "biomesoplenty:pasture", "biomesoplenty:prairie", "biomesoplenty:pumpkin_patch", "biomesoplenty:rainforest", "biomesoplenty:redwood_forest", "biomesoplenty:rocky_rainforest", "biomesoplenty:rocky_shrubland", "biomesoplenty:scrubland", "biomesoplenty:seasonal_forest", "biomesoplenty:seasonal_orchard", "biomesoplenty:shrubland", "biomesoplenty:snowblossom_grove", "biomesoplenty:snowy_coniferous_forest", "biomesoplenty:snowy_fir_clearing", "biomesoplenty:snowy_maple_woods", "biomesoplenty:spider_nest", "biomesoplenty:tropics", "biomesoplenty:tundra", "biomesoplenty:undergrowth", "biomesoplenty:visceral_heap", "biomesoplenty:volcanic_plains", "biomesoplenty:volcano", "biomesoplenty:wasteland", "biomesoplenty:wasteland_steppe", "biomesoplenty:wetland", "biomesoplenty:withered_abyss", "biomesoplenty:woodland", "deep_aether:aerglow_forest", "deep_aether:aerlavender_fields", "deep_aether:blue_aerglow_forest", "deep_aether:golden_grove", "deep_aether:golden_heights", "deep_aether:mystic_aerglow_forest", "deep_aether:yagroot_swamp", "integrateddynamics:meneglin", "minecraft:badlands", "minecraft:bamboo_jungle", "minecraft:basalt_deltas", "minecraft:beach", "minecraft:birch_forest", "minecraft:cherry_grove", "minecraft:cold_ocean", "minecraft:crimson_forest", "minecraft:dark_forest", "minecraft:deep_cold_ocean", "minecraft:deep_dark", "minecraft:deep_frozen_ocean", "minecraft:deep_lukewarm_ocean", "minecraft:deep_ocean", "minecraft:desert", "minecraft:dripstone_caves", "minecraft:end_barrens", "minecraft:end_highlands", "minecraft:end_midlands", "minecraft:eroded_badlands", "minecraft:flower_forest", "minecraft:forest", "minecraft:frozen_ocean", "minecraft:frozen_peaks", "minecraft:frozen_river", "minecraft:grove", "minecraft:ice_spikes", "minecraft:jagged_peaks", "minecraft:jungle", "minecraft:lukewarm_ocean", "minecraft:lush_caves", "minecraft:mangrove_swamp", "minecraft:meadow", "minecraft:mushroom_fields", "minecraft:nether_wastes", "minecraft:ocean", "minecraft:old_growth_birch_forest", "minecraft:old_growth_pine_taiga", "minecraft:old_growth_spruce_taiga", "minecraft:plains", "minecraft:river", "minecraft:savanna", "minecraft:savanna_plateau", "minecraft:small_end_islands", "minecraft:snowy_beach", "minecraft:snowy_plains", "minecraft:snowy_slopes", "minecraft:snowy_taiga", "minecraft:soul_sand_valley", "minecraft:sparse_jungle", "minecraft:stony_peaks", "minecraft:stony_shore", "minecraft:sunflower_plains", "minecraft:swamp", "minecraft:taiga", "minecraft:the_end", "minecraft:the_void", "minecraft:warm_ocean", "minecraft:warped_forest", "minecraft:windswept_forest", "minecraft:windswept_gravelly_hills", "minecraft:windswept_hills", "minecraft:windswept_savanna", "minecraft:wooded_badlands", "mythicbotany:alfheim_hills", "mythicbotany:alfheim_lakes", "mythicbotany:alfheim_plains", "mythicbotany:dreamwood_forest", "mythicbotany:golden_fields" ] }

botania/tags/worldgen/biome/mystical_flower_spawnlist.json: { "replace": true, "values": [ "twilightforest:clearing", "twilightforest:dark_forest", "twilightforest:dark_forest_center", "twilightforest:dense_forest", "twilightforest:dense_mushroom_forest", "twilightforest:enchanted_forest", "twilightforest:final_plateau", "twilightforest:fire_swamp", "twilightforest:firefly_forest", "twilightforest:forest", "twilightforest:glacier", "twilightforest:highlands", "twilightforest:lake", "twilightforest:mushroom_forest", "twilightforest:oak_savannah", "twilightforest:snowy_forest", "twilightforest:spooky_forest", "twilightforest:stream", "twilightforest:swamp", "twilightforest:thornlands", "twilightforest:underground" ] }