search

VazkiiMods / Neat

Functional minimalistic Unit Frames for the modern Minecrafter
Other
70 stars 72 forks source link

Neat gives extended right-click reach #120

Closed SamB440 closed 1 year ago

SamB440 commented 1 year ago

Using the neat mod provides extended right-click reach - I've seen it going up to 4.6 blocks!

The following video demonstrates this, where this is clearly not legitimate behaviour: https://www.youtube.com/watch?v=XqLKqzpp1MA. Health bars do not show in the video because I tried to turn "Max Distance" down to 3 in the config to see if that was part of the issue.

I am using Forge and the only mod installed is neat. This only happens when neat is installed. I am using the latest file from Curseforge: Neat-1.19-32.

I'm gonna take a guess that HealthBarRenderer#getEntityLookedAt is where the problem comes from. I can't see anywhere else that could modify reach, but I haven't looked into it too deeply. The problem also occurs with entities such as armour stands.

SamB440 commented 1 year ago

Turns out this is Forge itself - who would have thought? Guess I didn't test properly without neat installed. Sorry for any trouble caused. See https://github.com/MinecraftForge/MinecraftForge/issues/9309.