VazkiiMods / Neat

Functional minimalistic Unit Frames for the modern Minecrafter
Other
70 stars 72 forks source link

crash on mc 1.20 #133

Closed Devilswarchild closed 3 months ago

Devilswarchild commented 1 year ago

Crashing During bootup sequence before I even get to the main menu.

Minecraft Version: 1.20 Forge Version: 46.0.14

launcher_log

debug

latest

crash report

Current Modlist:

Architectury API (Fabric/Forge) (by shedaniel)

SuperMartijn642's Core Lib (by SuperMartijn642)

AI Improvements (by QueenOfMissiles)

Double Doors (by Serilum)

Jade 🔍 (by Snownee_)

SuperMartijn642's Config Lib (by SuperMartijn642)

Cosmetic Armor Reworked (by LainMI)

Ambient Environment (by Jaredlll08)

Not Enough Crashes (Forge) (by NatanFudge)

Wormhole (Portals) (by SuperMartijn642)

Corail Woodcutter (by Corail_31)

Entity Culling Fabric/Forge (by tr7zw)

Biomes O' Plenty (by Forstride)

Exotelcraft (by TKD_Kedis)

FerriteCore (Forge) (by malte0811)

Vanilla Plus Tools (by Raycoms)

Rubidium Extra (by dimadencep)

Croptopia (by thethonk)

Craftable Horse Armour & Saddle [CHA&S] (by EwyBoy)

Oculus (by Asek3)

Just Enough Items (JEI) (by mezz)

Macaw's Fences - Biomes O' Plenty (by Samlegamer_)

AmbientSounds 5 (by CreativeMD)

Ash API (by Trikzon)

MidnightLib (by TeamMidnightDust)

Clumps (by Jaredlll08)

Falling Leaves (Forge) (by Cheaterpaul)

Transparent (by Trikzon)

Inventory Sorter (by cpw)

Additional Lanterns (by SuperMartijn642)

Immersive Structures II: Nether edition (by ChoiceTheorem)

PlayerRevive (by CreativeMD)

Alex's Mobs (by sbom_xela)

ForgeEndertech (by EnderLanky)

Ultris: Boss Expansion (by limesplatus)

Immersive structures (by ChoiceTheorem)

TerraBlender (Forge) (by TheAdubbz)

Puzzles Lib [Forge & Fabric] (by Fuzs)

CreativeCore (by CreativeMD)

Large Ore Deposits (by EnderLanky)

Collective (by Serilum)

Neat (by Vazkii)

Advanced Chimneys (by EnderLanky)

Skin Layers 3D (Fabric/Forge) (by tr7zw)

Sound Physics Remastered (by henkelmax)

Game Menu Mod Option [Forge] (by morimori0317)

VillagersPlus (FORGE) (by finallion_13)

Portable Crafting Table (by 00theblackwolf00)

JourneyMap (by techbrew)

Rubidium (by Asek3)

TieFix (by j_t_a_i)

Packed Up (Backpacks) (by SuperMartijn642)

Log Begone (by AzureDoomC)

CTD Core (by TheMasterGeneral)

Visual Overhaul (by Motschen)

Armourer's Workshop (by RiskyKen)

Corail Pillar (by Corail_31)

Mo' Glowstone (by TheMasterGeneral)

Pam's HarvestCraft 2 - Food Core (by pamharvestcraft)

Leaves Be Gone (by Fuzs)

Macaw's Fences and Walls (by sketch_macaw)

Physics Mod (by haubna)

Citadel (by sbom_xela)

Borderless Window (by nekeras)

Corpse (by henkelmax)

Get It Together, Drops! (by bl4ckscor3)

williewillus commented 1 year ago

mixin conflict with Exotelcraft.

Unfortunately, that mod is not open source, making investigation impossible. There's nothing we can do here.

Devilswarchild commented 1 year ago

I will let the author know

On Fri, Jun 16, 2023, 9:45 AM Vincent Lee @.***> wrote:

mixin conflict with Exotelcraft.

Unfortunately, that mod is not open source, making investigation impossible. There's nothing we can do here.

— Reply to this email directly, view it on GitHub https://github.com/VazkiiMods/Neat/issues/133#issuecomment-1594812948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQ53KVW75TWA5Y33ZSZ4N3XLRWO5ANCNFSM6AAAAAAZDUP7N4 . You are receiving this because you authored the thread.Message ID: @.***>

Devilswarchild commented 1 year ago

heard back from the author.

this is what he had to say:

Screenshot_2

Screenshot_3

Devilswarchild commented 1 year ago

any progress on an update? cause i believe this is also the same error that is happening in 1.20.1 now too

Devilswarchild commented 1 year ago

I can provide the logs for those as well if need be

crash-2023-06-23_18.41.08-client.txt debug.log latest.log launcher_log.txt

williewillus commented 1 year ago

Mods should not be doing @Overwrite, it's incredibly uncomposable. While I can move the Neat mixin injection somewhere else (I haven't verified whether it's actually safe as that person says), who's to say some other mod won't overwrite that method too?

Additionally, IMO the onus is on the author of the closed-source mod to be compatible with the ecosystem, not the other way around.

Devilswarchild commented 1 year ago

I wholeheartedly agree and I have been considering removing exotelcraft altogether since he wont be doing anything to his mod prior to 1.20.x

Devilswarchild commented 1 year ago

I think I will just remove the mod since its very much in bad form anyway atleast from the coding perspective

Devilswarchild commented 1 year ago

and with that mod gone I can now resume using neat without any issues

Devilswarchild commented 1 year ago

he now has this to say

image

Uraneptus commented 3 months ago

I will close this since it's a year old!