search

VazkiiMods / Neat

Functional minimalistic Unit Frames for the modern Minecrafter
Other
70 stars 72 forks source link

[Feature?] Nametag Rendering Disables Players Too #163

Closed Fyoncle closed 1 month ago

Fyoncle commented 1 month ago

As the title states, if vanilla nametag rendering disabled, it also disables player names instead of only animals. Which is if you wanna get rid of the vanilla nametag only because Neat displaying it for them (i have players disabled) it will also hide it for the player.

It would be nice if it was a seperate config or not a thing at all.

Uraneptus commented 1 month ago

Oh that's interesting and def not intended. I'll get a fix out soon!

Fyoncle commented 1 month ago

Oh that's interesting and def not intended. I'll get a fix out soon!

Thanks! I use 1.20.1 Fabric if that helps

ItsShamed commented 1 month ago

I think I got a patch working should I PR it?

2024-10-20_13 32 44

Fyoncle commented 1 month ago

It seems like hiding the Neat by the keybind also doesn't return the vanilla nametag rendering but instead HIDE EVERYTHING

ItsShamed commented 1 month ago

Something like this?

https://github.com/user-attachments/assets/628364f7-0ead-422c-a55d-379bca14cb34

Uraneptus commented 1 month ago

Already got an uncomitted fix, but I wanna test a few more things first

Fyoncle commented 1 month ago

Something like this?

neat_demo.mp4

Yes!!

Uraneptus commented 1 month ago

added and will be released soon

Fyoncle commented 1 month ago

added and will be released soon

Much appreciated ❤️