search

VazkiiMods / Quark

Small things, improving Minecraft without changing the core gameplay.
https://quark.vazkii.net
Other
586 stars 288 forks source link

basalt doesn't generate more in overworld #120

Closed 0Navis0 closed 8 years ago

0Navis0 commented 8 years ago

I'm not sure if it's normal, but in the 42 Quark version, the basalt doesn't generate more in the overworld, even when the option in the config fime is activated.

KnightMiner commented 8 years ago

Basalt generates in the nether last I checked.

0Navis0 commented 8 years ago

Yes I know, but not more in the overworld.

Vazkii commented 8 years ago

Generating in the overworld is a config option that's off by default. Did you reset your config files?

0Navis0 commented 8 years ago

I know, I put the option in true, but it doesn't work.

0Navis0 commented 8 years ago

Damn it's what I thought, a mod prevents the basalt to generate correctly in the overworld. Now I will have to add ones by ones all my mods for seeing wich one do it.

yrsegal commented 8 years ago

Which mod? On Thu, Jul 14, 2016 at 10:33 AM Alexis GEORGES notifications@github.com wrote:

Damn it's what I thought, a mod prevents the basalt to generate correctly in the overworld. Now I will have to add ones by ones all my mods for seeing wich one do it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Vazkii/Quark/issues/120#issuecomment-232683231, or mute the thread https://github.com/notifications/unsubscribe/AGSnjIf5NIa__a4R2GeF3Fx8F7rWagE5ks5qVkjLgaJpZM4JLvAJ .

0Navis0 commented 8 years ago

It's what I will try to discover now. It will take a bit of time before I find it.

0Navis0 commented 8 years ago

And I finally finded the mod wich mess with the basalt generation, it's DynamicSurrounding. It mess too with Limestone and Marble of Chisel. So there is definitely something wrong with this mod for the ores generation.

0Navis0 commented 8 years ago

Is there someone here who knows what could cause this problem ? Because for the DynamicSurroundings dev, except to tell me that I'm stupid and that I understand nothing, he seems to be unable to solve the problem, mainly because he doesn't want and anyway it's not his fault...

Vazkii commented 8 years ago

Definitely not DynamicSurroundings, it's a client side mod.

WanionCane commented 8 years ago

i can confirm what Hypsellis is saying, i tested with both Quark, and Dynamic Surroundings, and in fact Basalt is not being generated. without it is being generated.

Vazkii commented 8 years ago

Hm, apparently it is not client side only, I stand corrected. Any word on this @Abastro ?

0Navis0 commented 8 years ago

Thanks friend for the support. And this is annoying to have to deal with dev who never admit that a problem can happen and tell you that in fact it's you who is stupid and that you understood nothing. So before to criticize the people, try it and see if the problem is true.

I don't report issues for the pleasure or for annoying people. It annoyes me as much as you. I'm a modpack creator and I deal with problems between mods all the days, and at each time I must find wich mods cause the problem when I don't have any crash report, and you haven't any ideas how much it's annoying to do it when you have 150 mods.

So after when I hear that I'm totally stupid and I understand nothing, it's really not nice. I don't know what you people imagine you, but I think there is clearly a problem of paranoia here. I don't necessarily target you Vazkii, I have nothing wrong against you, you are an awesome dev, it's just something general I noticed to many developpers.

Vazkii commented 8 years ago

This is off topic, but it comes from the fact that a good amount of people do in fact have no idea what they're doing.

If you actively try to reproduce every bug which can be caused via a million different interferences from other mods or old versions, you'll never get anything done. Especially when the issue is missing critical information such as a log or a complete mod list.

It's nothing against the users, but when more than half of the issues are fixed with "update the mod" or similar, you start to grow weary.

0Navis0 commented 8 years ago

I understand Vazkii, but it's not a reason for considering that what the users report you is always wrong and that they understand nothing.

Anway here is the log if it can help you. http://pastebin.com/jbg84R5k

Vazkii commented 8 years ago

It doesn't really help me in this case, no.

0Navis0 commented 8 years ago

I can't help you more, I already told you everything I knew about this problem.

Vazkii commented 8 years ago

Indeed, if it doesn't work with DS, it must be a weird conflict somewhere. Waiting on comment from Abastro.

Abastro commented 8 years ago

DS and its unofficial port on server side sends some packets related with world information, and apply few changes to the WorldProvider. How does the oregen of the basalt use the WorldProvider?

Vazkii commented 8 years ago

It just uses a standard generator. https://github.com/Vazkii/Quark/blob/master/src/main/java/vazkii/quark/world/world/BasaltGenerator.java

Abastro commented 8 years ago

Instanceof check with WorldProviderSurface would not be proper way to check for overworld, as mods like DS and TerrafirmaCraft does not inherit it.

Vazkii commented 8 years ago

What would be a better option?

yrsegal commented 8 years ago

WorldProvider#getDimensionType()