search

VazkiiMods / Quark

Small things, improving Minecraft without changing the core gameplay.
https://quark.vazkii.net
Other
587 stars 287 forks source link

[1.18.2][Compatibility] 'Item Sharing' module is not compatible with Chat Heads #3797

Closed qznfbnj closed 2 years ago

qznfbnj commented 2 years ago
  1. Install Forge-1.18.2-40.1.52
  2. Install chat_heads-0.6.0-forge-1.18.1 alongside Quark-3.2-358
  3. Startup and crash

If comment out "client.ChatComponentMixin" in quark.mixins.json, game can run normally. But 'Render Items In Chat' function in 'Item Sharing' module will render nothing. chatheads-quark Because I can't figure out whose fault it is, I will submit to another at the same time: https://github.com/dzwdz/chat_heads/issues/28.

Useless stuff: Latest.log Debug.log Crash Report

Fourmisain commented 2 years ago

Chat Heads maintainer here, I fixed this on our end.

The issue was that Chat Heads targets the Font.drawShadow call that ChatComponentMixin redirects, so when Quark's mixin is loaded before Chat Heads' mixin, it won't be able to find the method.

Quark's @Redirect could be replaced by a @ModifyArgs for better compatibility, but it would make the code uglier (and a little bit less efficient), hence I just opted to adjust the Mixin priority on our side.