VazkiiMods / Quark

Small things, improving Minecraft without changing the core gameplay.
https://quark.vazkii.net
Other
565 stars 280 forks source link

Log spam - Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner} #4764

Open sciguyryan opened 4 months ago

sciguyryan commented 4 months ago

Hi.

While putting together a mod pack I noticed the following appearing a lot in my logs.

[18:44:05] [Render thread/WARN] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner}

It doesn't seem like it's intended to do that and something has clearly gone wrong, though nothing is amiss as far as I can see. I figured it's worth reporting just in case. If nothing else it causes a fair amount of log spam.

I've reported it here because Zeta is specifically cited in the warning, but it might be a Quark issue. I'm not certain.

ChloeDawn commented 4 months ago

I'm also experiencing this (seems intermittent?) and it results in entire creative tabs vanishing from the menu. Here is a copy of my log from it occuring in my modpack: https://mclo.gs/lDVsVIk I suspect it may be trigged from Copycats+ performing on-demand rebuilding of creative tabs for their feature config. EDIT: I was able to reproduce without Copycats+: https://mclo.gs/Z504Kqb

sciguyryan commented 4 months ago

Copycats+

It's definitely not Copycats+ in my case since I'm not using it in my pack. Nice to see someone else has spotted this too though!

Krimatoria commented 4 months ago

Forge 1.20.1 https://gist.github.com/Krimatoria/67b12b73a06d7c02cd86a1210a9f99fe - Log

[19:36:37] [Thread-45/WARN] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner} java.lang.RuntimeException: Creative tab placement misses exceeded failsafe, aborting logic at TRANSFORMER/zeta@1.0-14/org.violetmoon.zeta.registry.CreativeTabManager.buildContents(CreativeTabManager.java:141) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) at LAYER PLUGIN/javafmllanguage@1.20.1-47.2.7/net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:114) at LAYER PLUGIN/fmlcore@1.20.1-47.2.7/net.minecraftforge.fml.ModLoader.lambda$postEvent$29(ModLoader.java:326) at java.base/java.lang.Iterable.forEach(Unknown Source) at LAYER PLUGIN/fmlcore@1.20.1-47.2.7/net.minecraftforge.fml.ModList.forEachModInOrder(ModList.java:227) at LAYER PLUGIN/fmlcore@1.20.1-47.2.7/net.minecraftforge.fml.ModLoader.postEvent(ModLoader.java:326) at TRANSFORMER/forge@47.2.7/net.minecraftforge.common.ForgeHooks.onCreativeModeTabBuildContents(ForgeHooks.java:1633) at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.CreativeModeTab.m269498(CreativeModeTab.java:129) at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.CreativeModeTabs.m268957(CreativeModeTabs.java:1696) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) at java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) at java.base/java.util.Iterator.forEachRemaining(Unknown Source) at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source) at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source) at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source) at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.CreativeModeTabs.m269421(CreativeModeTabs.java:1695) at TRANSFORMER/minecraft@1.20.1/net.minecraft.world.item.CreativeModeTabs.m269226(CreativeModeTabs.java:1710) at TRANSFORMER/emi@1.1.2+1.20.1+forge/dev.emi.emi.registry.EmiStackList.reload(EmiStackList.java:62) at TRANSFORMER/emi@1.1.2+1.20.1+forge/dev.emi.emi.runtime.EmiReloadManager$ReloadWorker.run(EmiReloadManager.java:173) at java.base/java.lang.Thread.run(Unknown Source)

BigPhobos commented 4 months ago

Also experiencing significant issues with this bug. It completely hides the contents of entire creative tabs.

3ncanis commented 3 months ago

Experiencing this as well

kaebiene commented 3 months ago

I think this is related to Every Compat somehow - I had the exact same error (and missing torches in JEI along with other items), and removing Every Compat solved the issue.

Needs more testing, but just in case!

Edit: Never mind, error still being thrown (but items returned)

3ncanis commented 3 months ago

Seems to be just any mod that adds a lot of new items/blocks from what I can tell, if I make Supplementaries go into it's own creative tab it happens less but still occasionally does.

Vazkii commented 3 months ago

I added some debugging tools to the config. If you can still reproduce this in the next version please reach out to me on discord.

Vazkii commented 2 months ago

Looks like this is still happening. Version 1.0-16 should have more options to test.

I personally have never managed to reproduce this issue, so here's some points I think could be good to try and figure it out:

Asking for anyone who can reproduce this to reach out on discord as well so we can try and track it down, thank you.

MrChunks commented 2 months ago

I'm a bit new to bug reporting MC stuff, but I have the same error (on a relatively fresh ATM9 modback install, ATM9 0.2.58 )

I turned on verbose logging captured the following. I hope it's what you're looking for. I don't get an error/stacktrace, but I do get a ton of this spam:

(file attached) logsnip.txt

It keeps on going. I can share a full log if that would help too, but maybe I'm not sharing anything useful, so I didn't want to clutter up the thread more than I already am.

MaxWasUnavailable commented 17 hours ago

Still happening in 1.20.1 with version 1.0-19