[1.20.1] Matrix Enchanting deletes NBT from certain tools

VazkiiMods / Quark

Small things, improving Minecraft without changing the core gameplay.

https://quark.vazkii.net

Other

584 stars 287 forks source link

[1.20.1] Matrix Enchanting deletes NBT from certain tools #4837

Open FoxMcloud5655 opened 3 months ago

FoxMcloud5655 commented 3 months ago

When inserting some tools that have extra NBT data on it into the Matrix Enchanting GUI, the data is cleared. This issue is most prominent with Draconic Evolution's tools, as it deletes all installed modules.

Minecraft: 1.20.1 Forge: 47.2.20 Zeta: 1.0-19 Quark: 4.0-458 Draconic Evolution (for testing if needed): 3.1.2.575

quat1024 commented 2 months ago

I can't reproduce this with vanilla tools in the table. Hmm. Two questions:

Are you in creative mode? (longstanding Forge bug, basically any item that uses "item capabilities" is prone to deleting them in creative mode, for example https://github.com/BluSunrize/ImmersiveEngineering/issues/5761)
Are you shift clicking the items in, or dropping them in with left mouse click? (different code paths)

FoxMcloud5655 commented 2 months ago

No, I was not in Creative mode. I know about this issue, and it's extremely similar, but it doesn't happen just in Creative mode. I'm pretty sure I used the Shift+Click method, but I would have to test and get back to you on that.

Regardless, Draconic Evolution does use capabilities to access the modular information, but Creative mode works correctly. I know that it was an issue before, but either Brandon patched the Creative menu or saves the data some other way now. Or, Forge fixed the issue.