VazkiiMods / Quark

Small things, improving Minecraft without changing the core gameplay.
https://quark.vazkii.net
Other
586 stars 288 forks source link

[1.20.1] Observers always on after being pushed by a piston during its pulse #4861

Open joshlev1s opened 3 months ago

joshlev1s commented 3 months ago

With Quark Automation disabled:

https://github.com/user-attachments/assets/4de05e20-aa8a-4c32-86f2-1567e47080a0

https://github.com/user-attachments/assets/39e2c952-f416-4fb6-bcae-20a2a9b5f403

Without Quark:

https://github.com/user-attachments/assets/e452fa8a-af9b-46c2-9024-aef884bd4307

latest.log https://pastebin.com/sYrUYnk8

MehVahdJukaar commented 3 months ago

I'm not sure whats going on. In second video you sent the observer oes turn off

MehVahdJukaar commented 3 months ago

also do you known which module in particular does this? is it the piston move tile entities one?

joshlev1s commented 3 months ago

also do you known which module in particular does this? is it the piston move tile entities one?

Sorry if the first video wasn’t clear. The first two videos are with all automation settings disabled as then you’d expect vanilla behaviour I thought.

In the first video I place the observer in front of the piston and break the block in front of the observer so the piston is powered and pushes the observer during its pulse. I do the same thing in the third video with Quark removed from the mod list. By doing this with Quark installed with all automation disabled, the observer always stays on.

The second video is to show that it doesn’t always stay on when it isn’t pushed during its pulse. Again with all automation settings disabled.

joshlev1s commented 3 months ago

Didn’t mean to press closed with comment

Vazkii commented 3 months ago

This looks like a Zeta issue in its piston reimplementation then

LeoBeliik commented 3 months ago

I'm quite sure this predates zeta since it seems related to #4556

Vazkii commented 3 months ago

The Zeta piston implementation is the old Quark piston implementation so it makes sense