VazkiiMods / Zeta

Modular Mod development framework
Other
21 stars 5 forks source link

Rethink `RecipeCrawlHandler.recursivelyFindCraftedItems` allow/denylist behavior #2

Open quat1024 opened 6 months ago

quat1024 commented 6 months ago

As was pointed out in https://github.com/VazkiiMods/Quark/issues/4648, the "whitelist" / "blacklist" parameters to RecipeCrawlHandler are not terribly useful:

The whitelist/blacklist parameters do not meaningfully affect the recursive parts of the recipe crawl algorithm, all it really does is call massRegistryGet on your behalf.

Especially in the case of Quark's Magnet System, usage of the whitelist/blacklist parameters creates a situation where you need to enter item IDs, but you really mean to enter block IDs.

MehVahdJukaar commented 3 weeks ago

I'm not sure im understanding this right but one use of having a whitelist that affects the recipe crawl is to remove certain items derivated from others. For example having the recipe crawl remove blacklisted stuff like tripwire would fix blocks like shulker boxes and trapped chests from being considered magnetic