search

VazkiiMods / Zeta

Modular Mod development framework
Other
23 stars 6 forks source link

Catch exceptions in ForgeEventRemapper #47

Closed ProjectHSI closed 3 months ago

ProjectHSI commented 3 months ago

https://github.com/VazkiiMods/Zeta/blob/1d68bb4827f7373b060ff3605a8d99a092e2f7eb/src/main/java/org/violetmoon/zetaimplforge/event/ForgeEventsRemapper.java#L123 doesn't catch exceptions which occur in other mods, which causes crashes as the exceptions travel upstream causing a crash.

ProjectHSI commented 3 months ago

Apparently, this already catches exceptions, but it appears that the Throwable catch - for whatever, does catch the NullPointerException caused by the Create: Dreams and Desires crash. Therefore this is unfixable on Zeta's side.