search

VazkiiModsArchive / Ambience

Your music in minecraft
25 stars 49 forks source link

Fixed for 1.11, 100% working #26

Closed Dalethium closed 7 years ago

Dalethium commented 7 years ago

a few fixes that allow this mod to work in 1.11.2

Dalethium commented 7 years ago

I found a error and created a fix for it, testing it now. Stacktrace: at net.minecraftforge.fml.common.eventhandler.Event.setCanceled(Event.java:93) at vazkii.ambience.Ambience.onBackgroundMusic(Ambience.java:160) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_11_Ambience_onBackgroundMusic_PlaySoundEvent.invoke(.dynamic) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) at net.minecraftforge.client.ForgeHooksClient.playSound(ForgeHooksClient.java:367) at net.minecraft.client.audio.SoundManager.func_148611_c(SoundManager.java:344) at net.minecraft.client.audio.SoundHandler.func_147682_a(SourceFile:195) at net.minecraft.client.audio.MusicTicker.func_181558_a(SourceFile:49) at net.minecraft.client.gui.GuiWinGame.func_73876_c(SourceFile:44)

Dalethium commented 7 years ago

I fixed the error, I basically muted the music since you can't cancel it I suppose.

Dalethium commented 7 years ago

@liam4 better?

CircuitLord commented 7 years ago

Could you pre-compile your fork for me into the jar? I just tried to compile it myself, but as I haven't done it in a while, I'm not exactly sure where the gradlew.bat build command is outputting to.

Vazkii commented 7 years ago

👍

CircuitLord commented 7 years ago

That works too :D

CircuitLord commented 7 years ago

Lol, pretty much right after he merged them, I realised where gradlew was putting the compiled mod.