VazkiiModsArchive / Ambience

Your music in minecraft
25 stars 49 forks source link

[Bug/Issue] Rain Event Music #50

Open GrzechuGrek opened 6 years ago

GrzechuGrek commented 6 years ago

There is issue on rain event music: If player is hidden under least one block(example leaves of tree), then rain event music is stop playing, although still rain is present. I think this rain event music should to play independent if player covered off from rain or not.

phen0menal commented 6 years ago

This issue is still present too, it should be changed so it plays where ever you are while it rains, adds a nice feel.

towerofnix commented 6 years ago

Perhaps the easiest change would be to make it only play if the player also hears raindrops at the same time (or, if they would hear raindrops, if weather sounds are disabled).

GrzechuGrek commented 6 years ago

Just a small change in the code to make everything work properly(I know even where). ;)

towerofnix commented 6 years ago

@GrzechuGrek That's what pull requests are for, eh?

GrzechuGrek commented 6 years ago

@towerofnix Yes, just I did it.