Vdauphin / HeartsAndMinds

:heart::brain: 1.24.1 is out! 🎉
http://vdauphin.github.io/HeartsAndMinds/
110 stars 65 forks source link

Fix convoys with LAMBS AI mod #1505

Closed Zakant closed 1 year ago

Zakant commented 1 year ago

When merged this pull request will:

Final test:

Vdauphin commented 1 year ago

Hello, I am not quite sure if it belong to the official H&M to handle specific feature like this Also Lambs should not be use in mission that use waypoints https://github.com/Vdauphin/HeartsAndMinds/discussions/1077 Cheers

Zakant commented 1 year ago

I would argue it does. Lambs is quite popular as a mod, and the fix doesn't hurt the players that dont use it as it only sets a single variable on some units in some cases. Beside this particular issue we haven't noticed any problems with Lambs and H&M so I wouldn't say that they are incompatible per se.

Greetings

Vdauphin commented 1 year ago

What Lambs actually break for convoy side mission? and how?

Zakant commented 1 year ago

Lambs seems to have a problem with AI in one group that is split among too many vehicles. Vehicles then get "stuck" and don't move at all.

Vdauphin commented 1 year ago

H&M is not the only mission with convoy mission, may be a fix from Lambs should be better Like using VehicleAdded EH should be useful to detect if more than one vehicle is in a group https://community.bistudio.com/wiki/Arma_3:_Event_Handlers#VehicleAdded

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] commented 1 year ago

This PR was closed because it has been stalled for 10 days with no activity.