search

Vect0rZ / Quic.NET

A .NET C# Implementation of QUIC protocol - Google's experimental transport layer.
BSD 2-Clause "Simplified" License
376 stars 58 forks source link

QuicClient.CreateStream is hardcoded to 1. #3

Open angedelamort opened 5 years ago

angedelamort commented 5 years ago

I've changed my local version to:

public QuicStreamContext CreateStream(ulong streamId = 1, StreamType streamType = StreamType.ClientBidirectional);

in order to keep the compatibility.

Vect0rZ commented 5 years ago

Good catch. We can use a NumberSpace class instance here, it's part of QuicNet.Infrastructure. We can substitute the streamId optional parameter with a private NumberSpace in the QuicClient, and leave the streamType in place, so a client can choose whether is Uni/Bidirectional.

Still, let's merge that one in,

Thanks!