Set enum member on instruction with constant value

[fergofrog]

Often when comparisons against enum members (or #define constants) are compiled they become static mov r, val where val is the constant. Currently binary ninja allows enum members to be set against data, but not when in code. Implementing this would make for a much tidier disassembly, all the way up to the MLIL.

[plafosse]

Thanks for the feature request.

[xusheng6]

Related to https://github.com/Vector35/binaryninja-api/issues/2606

[xusheng6]

Related to https://github.com/Vector35/binaryninja-api/issues/2312

[xusheng6]

I tentatively suggest that we reopen issues like https://github.com/Vector35/binaryninja-api/issues/3211. That one is tracking a different issue than this one. This issue tracks the ability to manually specify an integer constant as an enum type, while #3211 seems to suggest we handle the enum better automatically. For example, we should be able to change the constant 2 to an enum name without user interaction in the following code:

100003ed8      enum foobar var_28
100003ed8      if (var_28 == 2)
100003ee8          _printf("foo3\n")

[xusheng6]

Related to #1703

[xusheng6]

This should be converted into several sub-tasks:

• [x] Do better type resolving/propagation on enums and figure out more constant values are enums automatically when possible
• [x] Provide a UI and API to mark a selected constant value as an enum type. The UI should try to automatically find all enum members across all known enums with the constant's value

[xusheng6]

The second task is blocked on #3490

[0cyn]

Resolved in builds >= 3.2.3974