Docs: get_instruction_low_level_il gets more data than documented

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja

https://binary.ninja/

MIT License

900 stars 204 forks source link

Docs: get_instruction_low_level_il gets more data than documented #1630

Closed nshp closed 1 year ago

nshp commented 4 years ago

https://github.com/Vector35/binaryninja-api/blob/6f863df807afdd111017a92cfc15c6f6a0d79310/python/architecture.py#L1503

I don't believe this is true. Maybe BN_MAX_INSTRUCTION_LENGTH? Maybe up to the end of the basic block? But definitely greater than Architecture.max_instruction_length

plafosse commented 4 years ago

Its only guaranteed to be up to max_instruction_length, but it is in fact as you guessed it up to the end of the basic block.

psifertex commented 4 years ago

Need to investigate all other APIs that claim to return max_instruction_length and validate them as well.

psifertex commented 1 year ago

Other APIs clarified and validated.