search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
927 stars 209 forks source link

LogListener class is missing from the Python API #4156

Closed xusheng6 closed 1 year ago

CouleeApps commented 1 year ago

Implemented on a branch here: https://github.com/Vector35/binaryninja-api/tree/test_py_loglistener

Also a corresponding branch on the core repo addressing performance concerns

plafosse commented 1 year ago

This is a somewhat intentional omission due to the performance concerns of calling into python and having to take the GIL in the middle of analysis. @CouleeApps 's change does address the major concern though and would probably be fine to integrate his code.

xusheng6 commented 1 year ago

Related to https://github.com/mandiant/capa/issues/1413

xusheng6 commented 1 year ago

I am not rushing to merge this since the capa issue can be mitigated using existing log infra: https://github.com/mandiant/capa/issues/1413#issuecomment-1507854165

xusheng6 commented 1 year ago

Duplicate of https://github.com/Vector35/binaryninja-api/issues/2236