Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
899 stars 203 forks source link

Tag icon in linear view gets duplicated when view frame width gets small #4307

Closed kristopax closed 1 year ago

kristopax commented 1 year ago

Version and Platform (required):

Bug Description: Tag icon in Linear View gets duplicated when the view frame width is squeezed small enough to cause the line to wrap to multiple lines.

Steps To Reproduce: Please provide all steps required to reproduce the behavior:

  1. Open any binary
  2. Navigate to a function start
  3. Select Linear View
  4. Right click -> Tags and Bookmarks -> Add Tag
  5. Select Needs Analysis tag
  6. Change the horizontal window size to shrink the view until the function signature wraps to multiple lines
  7. Verify that the '?' Tag icon is duplicated when the function signature line wraps

Expected Behavior: I expected only one tag icon to be displayed when the function signature wraps to multiple lines.

Screenshots:

Screen Shot 2023-05-18 at 10 57 47 PM
xusheng6 commented 1 year ago

Screenshot 2023-08-09 at 3 30 53 PM

The funny part of this bug is that we are rendering one more tag on each line down in the stack. The first line has one tag, the second has two, and the fifth line has five tags!