Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
907 stars 207 forks source link

horizontal scrolling in linear view #4533

Open tur11ng opened 1 year ago

tur11ng commented 1 year ago

I think the feature is clearly stated in the title. It is generally accepted for horizontal scrolling to work when pressing the Shift button while scrolling and also I think it would be great to have a "Toggle Line Wrap" option like in Visual Studio Code.

psifertex commented 1 year ago

I think we have an existing issue for better line wrapping somewhere and I strongly agree it's needed. If I can find the other issue I'll link to it here but will leave this open in the meantime.

Shift-scroll already does horizontal scrolling everywhere I just tried it. Can you be more specific about where it's needed and not working? I just tried a selection of the sidebars as well as graph view and linear view and they all behaved as expected.

xusheng6 commented 1 year ago

I think we have an existing issue for better line wrapping somewhere and I strongly agree it's needed. If I can find the other issue I'll link to it here but will leave this open in the meantime.

Shift-scroll already does horizontal scrolling everywhere I just tried it. Can you be more specific about where it's needed and not working? I just tried a selection of the sidebars as well as graph view and linear view and they all behaved as expected.

Are you looking for https://github.com/Vector35/binaryninja-api/issues/3289? That issue's title is not super great, since it actually asks for line-wrapping, not abbreviating the line.

psifertex commented 1 year ago

Yes! Thanks. I've renamed it.

psifertex commented 6 months ago

We've received another report of someone for whom sideways scrolling in linear view isn't working but I can't reproduce it here. If anyone with this issue can report back on what type of OS/window manager they're running into that would be helpful.

shironecko commented 3 months ago

Hey! Chiming in to say that sideways scrolling with Shift doesn't work for me in linear views on Windows 11/Binja Free 4.0.5336 (I'm evaluating it for purchase) Let me know if I can provide more info to pin down the problem! Seems like a minor thing but it's really disruptive.

psifertex commented 3 months ago

Thanks @shironecko -- are you running in a VM or native? Does the scroll-bar work if you click/drag it, but shift-scroll wheel does not? If you resize the window slightly, does that change the behavior?