Closed kristopax closed 1 year ago
Version and Platform (required):
Bug Description: When using the BinaryDataNotification class within a plugin (namely Sidekick), the following error now occurs:
Exception ignored on calling ctypes callback function: <bound method BinaryDataNotificationCallbacks._notification_barrier of <binaryninja.binaryview.BinaryDataNotificationCallbacks object at 0x28b75c550>> Traceback (most recent call last): File "/Applications/Binary Ninja.app/Contents/MacOS/plugins/../../Resources/python/binaryninja/binaryview.py", line 521, in _notification_barrier self._notify.notification_barrier(self._view) TypeError: notification_barrier() missing 1 required positional argument: 'view' Exception ignored on calling ctypes callback function: <bound method BinaryDataNotificationCallbacks._notification_barrier of <binaryninja.binaryview.BinaryDataNotificationCallbacks object at 0x28b75c550>> Traceback (most recent call last): File "/Applications/Binary Ninja.app/Contents/MacOS/plugins/../../Resources/python/binaryninja/binaryview.py", line 521, in _notification_barrier self._notify.notification_barrier(self._view) TypeError: notification_barrier() missing 1 required positional argument: 'view'
Steps To Reproduce: Please provide all steps required to reproduce the behavior:
Expected Behavior: No error should have been generated.
Screenshots:
Additional Information: We can make the following changes to fix the issue:
In binaryview.py:
def _notification_barrier(self, ctxt, view: core.BNBinaryView) -> int: try: return self._notify.notification_barrier(self._view) except OSError: log_error(traceback.format_exc())
and
def notification_barrier(self, view) -> int: return 0
Fixed in 3.5.4445-dev.
3.5.4445-dev
Version and Platform (required):
Bug Description: When using the BinaryDataNotification class within a plugin (namely Sidekick), the following error now occurs:
Steps To Reproduce: Please provide all steps required to reproduce the behavior:
Expected Behavior: No error should have been generated.
Screenshots:
Additional Information: We can make the following changes to fix the issue:
In binaryview.py:
and