search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
923 stars 209 forks source link

Reopening BNDB triggers analysis update #4596

Open negasora opened 1 year ago

negasora commented 1 year ago

This bug was introduced in 3.5.4437-dev

Steps To Reproduce:

  1. Open a BNDB created with the same version
  2. See analysis happening

Expected Behavior: Reanalysis shouldn't happen

Screenshots: If applicable, please add screenshots here to help explain your problem.

Additional Information: A binary that took 6 minutes for initial analysis has ~45 seconds of reanalysis after opening the bndb. This doesn't happen in 3.4.4271.

bpotchik commented 1 year ago

Fixed in 3.5.4507.

alexrp commented 1 year ago

This is still an issue for me on this BNDB. BN always spends time reanalyzing when I open it. Seems to be a relatively recent phenomenon (last couple of weeks?).

plafosse commented 1 year ago

Reopening this issue while we look into this.

alexrp commented 1 year ago

Perhaps worth noting that the unexpected analysis doesn't take as long as an actual full reanalysis that happens due to a BN update. 🤔

bpotchik commented 1 year ago

There are three remaining sources of function reanalysis on BNDB load. These sources have been here for a while though, so the reanalysis behavior should be back to what it was on the previous stable.