search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
919 stars 207 forks source link

Types not being properly applied on initial analysis #4720

Open yrp604 opened 11 months ago

yrp604 commented 11 months ago

Version and Platform (required):

Bug Description: The function parameter for _guard_dispatch_icall is not applying on initial analysis

Steps To Reproduce: Please provide all steps required to reproduce the behavior:

  1. Open ntoskrnl.exe and load the pdb
  2. Navigate to ExAllocateFromNPagedLookasideList
  3. Select the _guard_dispatch_icall call and hit y
  4. Hit enter, accepting the default
  5. See the IL change/get updated

Expected Behavior: If a function has a type signature, I expect it to be applied by default. Accepting a default value should not change the IL   Screenshots: Before: image

During: image

After: image

To be clear, I did not enter the type for _guard_dispatch_icall, binja was aware this was the type and was not applying it.

xusheng6 commented 11 months ago

This is an interesting bug that we should seek to prioritize.