search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
919 stars 207 forks source link

Manage plugin page stars differs on macos and windows #4936

Closed blue-devil closed 9 months ago

blue-devil commented 9 months ago

What is the feature you'd like to have? Hello. On manage plugin page, plugins have GitHub star count. On windows "star" is yellow but on macos it is empty. macos version also should be like windows one/

Is your feature request related to a problem? No, only GUI enhancement

Are any alternative solutions acceptable? No

Additional Information: It is just trivial but I wanted to add

With pictures it is more easy to tell:

On windows: star-win

On macos:

star-mac
fuzyll commented 9 months ago

We're asking Qt to render "⭐" (White Medium Star, U+2B50). Our default font, Inter, does not have a glyph for this. On Windows, it appears to fall back to Segoe UI Emoji to draw this. On macOS, it picks a different font.

There are three paths forward:

  1. Draw this glyph with the user's emoji font, which will probably result in something closer to what users expect to see.
  2. Draw an icon here instead so it's consistent across platforms.
  3. We close this entirely after other changes that replace the usage of GitHub stars with better statistics.

I vote for option 3, but if someone wants to choose 1 or 2 in the short-term (since we don't know if/when other plugin manager changes will happen), go for it.

blue-devil commented 9 months ago

I go for option two. A small png/svg icon will consistent on all platforms.

psifertex commented 9 months ago

As the person who committed (pun intended) this font crime, I went with option 4. Find a star that exists in the font we ship. Not triggering a full build for it but the next build that goes out will use the ★ character instead which is included in our font and as an added bonus will be more easily theme-able.