Deconflicted DebugInfo types have bad references

[CouleeApps]

Version and Platform (required):

• Binary Ninja Version: 4.0.4883-dev
• OS: Windows
• OS Version: 10
• CPU Architecture: x64

Bug Description: When loading a PDB, types whose name conflict with a type in the existing view have _DebugInfo appended to their name so they do not conflict. Unfortunately, when this happens, any references other types in the PDB make to that type are not updated to point to the updated name. This leads to _KPCR_DebugInfo referencing _KPRCB instead of _KPRCB_DebugInfo and structure members looking strange.

Steps To Reproduce:

1. Open ntoskrnl.exe from a recent windows
2. Find the type _KPCR_DebugInfo
3. Observe it references _KPRCB and not _KPRCB_DebugInfo and has like 0x8eff bytes of extra padding at the end

Expected Behavior: I expected renamed types to be referenced correctly by other types from the pdb.

Screenshots:

Additional Information: Possibly due to the types already referencing the bv type before rename happens and thus the NTRs are broken already

[plafosse]

Fixed in 4.0. 4898 Unfortunately due to time constraints in 4.0 release I'm reverting the changes that were made for type deconfliction to fix this issue. I created this new issue to track the resolution: #5083