search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
849 stars 194 forks source link

Document support for getting/setting default calling convention in Python API #5532

Closed whitequark closed 1 week ago

whitequark commented 1 month ago

Is this a general concept that needs to be documented or a specific API? Specific API.

What concept or API needs more documentation? This commit: https://github.com/Vector35/binaryninja-api/commit/75787e706c877a34a68c23c0d4f90ec5ff1e830c

Is this documentation related to a specific API? Python

Are there any known examples of people using this API/concept? No; it was just added

whitequark commented 1 month ago

Oh... so I got confused by the version I had updated (I misread the number) and by the online documentation (which seems to lag behind) and didn't realize that there is at least a mention of the set_default_calling_convention function in the docs, albeit empty.

I do feel that it is worth filling it out, especially given that without setting a calling convention to be a default one, it seems that HLIL results get significantly worse.

psifertex commented 1 week ago

Resolved in https://github.com/Vector35/binaryninja-api/pull/5705