search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
928 stars 209 forks source link

Add data renderer for CFString types #5586

Open jonpalmisc opened 2 years ago

jonpalmisc commented 2 years ago

Rendering CFString instances in linear view as Objective-C style strings, e.g. @"Hello, world!", would be far more useful than seeing the structure itself.

The code for this is already done, just needs to be cleaned up, checked-in, and merged.

0cyn commented 1 year ago

Resolved with Vector35/workflow_objc#46 / 3720bcbf6c967b06d8cdf51701dc2cf88cb0499d Available in BinaryNinja Builds >= 3.2.3973

jonpalmisc commented 1 year ago

This issue refers to rendering CFString structures in linear view (not references in HLIL, etc.). From reading the commit I don't believe this resolves this.

psifertex commented 1 year ago

Isn't that exactly what a datarenderer does?

https://github.com/Vector35/workflow_objc/pull/50/files

jonpalmisc commented 1 year ago

Yes, if considering what this original issue was made for. Kat's changes (fdc174dbd2245cb8d95c7c1c2d89898168312e33) render CFStrings as string literals inside of HLIL, i.e. a "code renderer" (via an arch hook) which we don't support yet.

The pull request you linked is separate (but addresses the original issue and the reason I reopened this).