The ios-aarch64 platform is added on top of the original mac-aarch64

[VisualEhrmanntraut]

Version and Platform (required):

• Binary Ninja Version: 4.1.5637-dev
• OS: macOS
• OS Version: 15.0 Beta (24A5279h)
• CPU Architecture: M1

Bug Description: I updated Binary Ninja and opened an iOS kernelcache bndb to resume work... waited and waited for the analysis... and... then noticed... huh???

Steps To Reproduce: Open an iOS bndb from a version before the iOS platform was added.

Expected Behavior: It should migrate the old platform to the new one and remove the old one.

Screenshots/Video Recording:

Binary: Can't, I don't think Apple would like that!

Additional Information: The reanalysis has been on-going for 6+ hours now. This was not the case before. It might be analysing both platforms.

[emesare]

Can you print out the architecture and platform for both functions?

>>> current_function.arch
...
>>> current_function.platform
...

I suspect that the duplication is occurring due to some extra platform or architecture, possibly the new iOS platform.

[river-li]

Look at the left bottom corner, after 6 hours of reanalysis it's still Phase 1. I think this may relate to #5141

[VisualEhrmanntraut]

I left it overnight and it finished. Seems like it was trying to analyse some weird function:

[Function warn] Skipping analysis for function at 0xfffffff007dfd5b8 : Exceeds 'analysis.limits.maxFunctionAnalysisTime'

(which is duplicated again)

@emesare yes, it's indeed because of the new iOS platform.

>>> current_function.platform
<platform: ios-aarch64>
>>> current_function.platform
<platform: mac-aarch64>