Open 0xFDFDFDFD opened 1 month ago
If you agree with 1 would adjusting this issue to read as "Populate xrefs of a function with callers through data var reference" be alright?
Hi there thanks for the fast reply!
I was playing around a bit to find out exactly what you mean.
If I understand you correctly you are worried that the dat_var type is inconsistent with the function type referenced.
Isn't that already case?
I modified a vtable member and added an additional argument:
Caller:
Vtable:
Called function:
Shouldn't the data_ref type (when in a vtable) and the vtable function type be linked or synchronized anyway?
Sorry i accidently closed the issue 😅
If I understand you correctly you are worried that the dat_var type is inconsistent with the function type referenced. Isn't that already case?
Sorry yes I made it sound like that wasn't the case, what I am worried will happen is a user will click through to the only referenced function and modify the function type there but not in the actual vtable type. I suppose if we did link the two function types I would be ok with this behavior.
The current behavior forces a user to recognize the distinction between the vtable and any referenced functions.
I don't feel to strongly one way or the other so if this is something people want it could be put behind an option which is disabled by default.
That would be amazing 👍
Version and Platform (required):
Bug Description: There are a few improvements which could be made to the handling of vtables.
If I double click a vtable member with only one outgoing data reference it should open the referenced function. Currently it opens the type window instead.
If I click on a vtable member function it should show its callers as code references. At the moment I have to go back to the vtable in the data section to the get the callers.
Steps To Reproduce:
Double click a member of a vtable.
Check xrefs on a member of a vtable
Expected Behavior:
It opens the referenced function
The cross reference view is populated with the callers of the function as code references.
Screenshots:
Double click issue:![vtable](https://github.com/user-attachments/assets/e91b792c-4ace-4b61-aeda-36ad50a031cf)
Xrefs not propagated![missing_xrefs](https://github.com/user-attachments/assets/93389c46-153f-49df-a056-4b7fa5a944fd)
Additional Information: Bndb and exe used. CppTestBinja.zip