search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
946 stars 214 forks source link

MemoryMap sections view has some selection artifacts #6077

Open plafosse opened 3 weeks ago

plafosse commented 3 weeks ago

Binary Ninja 4.2 dev

Painting of segment boarder has some artifacts sometimes. I don't have exact repro steps but select segments and scroll around is sections and you should see it

image

we're likely missing some re-paint call somewhere

negasora commented 3 weeks ago

That's highlighting related segments/sections

plafosse commented 3 weeks ago

No thats not what I'm talking about. You can see in the bottom image only one line is drawn compare that with the segments view where you can see the lines on the side as well. Galen was also able to reproduce this. I wish I had some repro steps...

plafosse commented 3 weeks ago

I was also get to to go completely unresponsive by clicking around only: image

negasora commented 3 weeks ago

Where were you clicking? Did you end up in raw view by navigating?

plafosse commented 3 weeks ago

Oh you're right thats what happened on the bottom image.... thats a little confusing.

galenbwill commented 1 week ago

repro steps (only on Windows, as far as I can tell):

  1. click a section towards the top of the list, observe the highlighted segment(s)
  2. move the section selection down by one (arrow key or mouse click) repeatedly
  3. observe each time the segment highlight moves down, it leaves behind a border artifact
  4. Also works the other way around, segments vs sections

(I posted a screen recording in private slack, search for silly monkey no banana segment)

ElykDeer commented 1 week ago

Repros on MacOS with Windows binaries (with Galen's steps, binary at top of same thread in private slack):

https://github.com/user-attachments/assets/c5884d50-c6d9-49ba-b9a6-66a60c9d404b