Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
941 stars 213 forks source link

Confusing default text in the "Set Stack Adjustment" dialog #6137

Closed xusheng6 closed 4 days ago

xusheng6 commented 1 week ago

In the set stack adjustment dialog, when the current address does not have a stack adjustment, the dialog shows the last value from the history ui/stackAdjustSizeHistory. This can be confusing since it can be understood as the current stack adjustment is the value shown, e.g., in the below screenshot, 0x4.

Screenshot 2024-11-15 at 11 46 05 AM

We should probably show it as 0x0 if the stack adjustment is indeed 0x0