search

Vector35 / binaryninja-api

Public API, examples, documentation and issues for Binary Ninja
https://binary.ninja/
MIT License
930 stars 210 forks source link

Comments Hidden Based on Proximity of Another Comment #6140

Closed utkonos closed 3 hours ago

utkonos commented 3 hours ago

Version and Platform (required):

Bug Description: When setting comments in a data section, if there is a comment immediately below it, it will be hidden.

Steps To Reproduce:

  1. Navigate to a data section of a PE.
  2. Click on a location in a struct
  3. Right click and add a comment
  4. Add the same comment to the address right above that one.
  5. Notice that the first comment is now hidden.

Expected Behavior: All comments visible regardless of presence of neighboring comments.

Screenshots/Video Recording:

https://github.com/user-attachments/assets/c53ff032-fbb6-4e8d-9878-061a68a2d041

psifertex commented 3 hours ago

This is already resolved on the latest dev, new stable should be out next week with this fix. Duplicate of https://github.com/Vector35/binaryninja-api/issues/5550

utkonos commented 2 hours ago

Issue search would be a legit use case for an LLM.

I tried, but not hard enough:

image
psifertex commented 2 hours ago

"is:open" is the main issue there. Well, also "not showing" is too specific since "hidden" is a synonym. It was actually recent enough that just "comment" would have been better.

I agree GH search could definitely be better. I often can't find issues I know exist.

fuzyll commented 2 hours ago

It still doesn't show with "closed". You'd have also needed "visible" instead of "showing". We really do need a fuzzy search with synonyms for some of these.

utkonos commented 2 hours ago

Could Sidekick do this? I would defintiely ask Sidekick before opening a bug issue.

psifertex commented 2 hours ago

Not currently but that's a great suggestion. We could probably feed it the list of all software issues and let users search that via sidekick in the UI.