search

Vector35 / community-plugins

Repository for community provided Binary Ninja plugins
MIT License
430 stars 34 forks source link

[NewPlugin] binja-il-hierarchy v1.2 #177

Closed fabianfreyer closed 2 years ago

fabianfreyer commented 2 years ago

Please add my plugin to the repository.

Yes, I've read the instructions, especially the part about creating an actual release and creating the tag.

I either used the UI, or the hub command to create a real release.

Author: Me Repo name: https://github.com/fabianfreyer/binja-il-hierarchy Release: 1.2

psifertex commented 2 years ago

What a great plugin idea! We should have done that natively.

Unfortunately though the plugin.json is invalid: remove spurious comma: https://github.com/fabianfreyer/binja-il-hierarchy/blob/main/plugin.json#L28 and escape the quotes in the license please: https://github.com/fabianfreyer/binja-il-hierarchy/blob/main/plugin.json#L15

fabianfreyer commented 2 years ago

Should be fixed. FWIW, the quotes in the license were put there by the "export to plugin" feature in snippets

psifertex commented 2 years ago

Oh! Thanks, that's good to know. I'll fix that upstream.

Uhh, let me fix that first since there's more escaped quotes that were missed in that release. :-(

psifertex commented 2 years ago

Generator should be fixed fwiw if you pull the latest snippets. Sorry about that!

psifertex commented 2 years ago

ping Any chance for an update so I can add to the plugin manager? Been working quite nicely as a manual install

psifertex commented 2 years ago

Oh! Nevermind, I totally missed it was fixed already. Sorry about that. :-)

Adding now.