Vector35 / community-plugins

Repository for community provided Binary Ninja plugins
MIT License
411 stars 32 forks source link

[NewPlugin] elbee analyze_char_arrays v1.0 #204

Closed elbee-cyber closed 1 year ago

elbee-cyber commented 1 year ago

Please add my plugin to the repository.

Yes, I've read the instructions, especially the part about creating an actual release and creating the tag.

I either used the UI, or the hub command to create a real release.

Author: elbee Repo name: https://github.com/elbee-cyber/analyze_char_arrays Release: https://github.com/elbee-cyber/analyze_char_arrays/releases/tag/1.0

psifertex commented 1 year ago

Assuming the automation works this should be live in a few minutes in the plugin manager. Thanks! Hopefully the plugin won't be needed when https://github.com/Vector35/binaryninja-api/issues/1637 lands but appreciate it until then!

elbee-cyber commented 1 year ago

I don't think the automation worked, some friends tried to install for a CTF and it's not appearing on the plugin manager nor is it available on my copy's plugin manager. Looked at the commits and noticed that the most recent plugin added besides mine also isn't appearing

psifertex commented 1 year ago

You didn't change the name from the sample plugin so unfortunately it's a name collision with the "sample plugin". I see you fixed it after the release but you need to generate a new release before it will pull the correct plugin.json information.

psifertex commented 1 year ago

The second most recent added plugin is correctly available afaict.

Screenshot 2023-01-18 at 4 27 35 PM
elbee-cyber commented 1 year ago

Sorry about that I'm honestly not too good with git, I created a new release. I also created a new tag, but I'm not sure if that was necessary

psifertex commented 1 year ago

No worries, you got it the second time, thanks. You might find the update/release process easier if you using release_helper. I wrote that specifically because I didn't want to mess with all the steps myself. 😉

psifertex commented 1 year ago

Also, for future updates, we're tracking the plugin automatically and will notice the release and trigger the update on our side after review, no issue necessary.