search

Vector35 / community-plugins

Repository for community provided Binary Ninja plugins
MIT License
479 stars 42 forks source link

[NewPlugin] Njord BNPyc 1.0.1 #214

Closed Njord0 closed 1 year ago

Njord0 commented 1 year ago

Please add my plugin to the repository.

Yes, I've read the instructions, especially the part about creating an actual release and creating the tag.

I either used the UI, or the hub command to create a real release.

Author: Me Repo name: BNpyc Release: 1.0.1

galenbwill commented 1 year ago

I would suggest adding a screenshot that shows some (or all) ILs alongside your disassembly.

Njord0 commented 1 year ago

I would suggest adding a screenshot that shows some (or all) ILs alongside your disassembly.

I will but IL lifting is not implemented, there isn't much to show yet.

galenbwill commented 1 year ago

I would suggest adding a screenshot that shows some (or all) ILs alongside your disassembly.

I will but IL lifting is not implemented, there isn't much to show yet.

Ok, that's fair. In that case, never mind the screenshot for now, but it's probably worth pointing out that lifting is not implemented yet, preferably towards the top of the readme.

Njord0 commented 1 year ago

I would suggest adding a screenshot that shows some (or all) ILs alongside your disassembly.

I will but IL lifting is not implemented, there isn't much to show yet.

Ok, that's fair. In that case, never mind the screenshot for now, but it's probably worth pointing out that lifting is not implemented yet, preferably towards the top of the readme.

You're right, I did create a new release with the edited readme. I also edited my initial comment.

psifertex commented 1 year ago

Thanks for the submission, plugin has been added.

Really curious to see how it works with some lifting, definitely wasn't something we expected given some of our limitations for virtual architectures on BN.

Also, as an FYI -- we're tracking new releases automatically no need to let us know when it's updated. I just kicked off the update, if it got 1.0.0 instead of 1.0.1 I'll make sure to run it again.