search

Vector35 / community-plugins

Repository for community provided Binary Ninja plugins
MIT License
410 stars 32 forks source link

[NewPlugin] moval0x1 CommentsAndSymbols v1.0.0 #223

Closed moval0x1 closed 6 months ago

moval0x1 commented 6 months ago

Please add my plugin to the repository.

Yes, I've read the instructions, especially the part about creating an actual release and creating the tag.

I either used the UI, or the hub command to create a real release.

Author: moval0x1 Repo name: https://github.com/moval0x1/CommentsAndSymbols Release: https://github.com/moval0x1/CommentsAndSymbols/releases/tag/1.0.0

psifertex commented 6 months ago

Added now, thanks!

The plugin could use a bit more documentation though. :-)

Would love to see an explanation of whether it's auto->user changes, only those that happen while the plugin is installed, etc.

psifertex commented 6 months ago

Looks like the import failed. I think your release name and your plugin version in the plugin.json aren't consistent. Consider maybe using https://github.com/Vector35/release_helper which can automate that process for you?

psifertex commented 6 months ago

Scratch that, there's some busted json in there:

python3 -mjson.tool < plugin.json
Expecting ',' delimiter: line 18 column 180 (char 505)
moval0x1 commented 6 months ago

Updated! It was the same error here in the plugin.json.

psifertex commented 6 months ago

Added, thanks!