Vector35 / deprecated-binaryninja-python

Deprecated Binary Ninja prototype written in Python
GNU General Public License v2.0
518 stars 128 forks source link

change PySide to PyQt5 #10

Open JaySon-Huang opened 9 years ago

JaySon-Huang commented 9 years ago

Here is a PR for using PyQt5 instead of PySide.

But I found that It maybe somewhat difficult for building PyQt5 under Python2 but not Python3. for example,

Take care of this before accepting this PR ;)

psifertex commented 9 years ago

Yikes -- first, thanks very much for isolating the PyQt5 bits from the formatting changes. I wish I'd known about the lack of binary packages as I probably wouldn't have even mentioned considering an upgrade if I'd known.

Thanks for making sure to mention that, I think we'll probably just keep an eye out to see if anybody else publishes some premade 2.7 binaries before we upgrade. We definitely want to keep cross-platform support and maintain the relatively easy install process it has now (couple of binary dependencies or apt repository installs) and it looks like PyQt5 doesn't offer a mechanism for us to do that right now.