Vector35 / snippets

plugin for storing and using snippets of useful Binja script
MIT License
22 stars 9 forks source link

Attempting to close an open snippets dialog during long analysis hangs UI #13

Closed galenbwill closed 3 years ago

galenbwill commented 3 years ago

If the snippets dialog is opened while a long analysis is in progress, attempting to close the dialog hangs the entire UI.

On macOS, this actually makes it impossible to switch to another application and have it show its window on top of the frozen snippets dialog.

Not sure if this unfreezes when the analysis completes, as I've always forced binary ninja to quit when this happens.

As an aside, it would be nice if the snippets dialog weren't modal, but that probably relates to issue https://github.com/Vector35/snippets/issues/10

psifertex commented 3 years ago

Making the window non-model fixes it somewhat -- BN UI can still hang (#4) but you can switch just fine.