search

VectorCamp / vectorscan

A portable fork of the high-performance regular expression matching library
https://www.vectorcamp.gr/project/vectorscan/
Other
503 stars 54 forks source link

Add truffle SVE implementation #217

Closed ypicchi-arm closed 8 months ago

ypicchi-arm commented 9 months ago

This PR adds an implementation of truffle using SVE as per planned in https://github.com/VectorCamp/vectorscan/issues/190. It speeds truffle's benchmark up by about 15% and pass the unit tests.

markos commented 9 months ago

@ypicchi-arm @paul-szczepanek-arm

Unfortunately compilation fails for fat runtimes on Arm (all compilers tested), this needs to be fixed in order for the PR to be merged.

https://buildbot-ci.vectorcamp.gr/#/builders/7/builds/68

markos commented 8 months ago

same failure, fat runtimes on arm build failure: https://buildbot-ci.vectorcamp.gr/#/builders/7/builds/69

I can look at it and fix it for this PR if you want, so we can merge it soon.

paul-szczepanek-arm commented 8 months ago

I can see the problem, sorry. Wait till tomorrow please, Yoan is away today - will fix tomorrow ASAP.

markos commented 8 months ago

Apologies, I just noticed, could you please resubmit this PR against develop branch? I really need to add some rules about PRs against master directly.

paul-szczepanek-arm commented 8 months ago

Sorry, I missed that, maybe you should put the information about the branches in the Contributing heading rather than Versioning in the readme.

markos commented 8 months ago

Sorry, I missed that, maybe you should put the information about the branches in the Contributing heading rather than Versioning in the readme.

Indeed, I will fix that. Again apologies, I'm also looking at how to forbid PRs directly to the master branch to avoid this in the future.

ypicchi-arm commented 8 months ago

This last update should only fix the conflict in the copyright section. The other apparent changes should only be because of the rebase to the develop branch. Sorry for missing that earlier.

paul-szczepanek-arm commented 8 months ago

you can set the default branch to develop - that will make the PRs default to it

markos commented 8 months ago

good tip, thanks!