VectorCamp / vectorscan

A portable fork of the high-performance regular expression matching library
https://www.vectorcamp.gr/project/vectorscan/
Other
478 stars 50 forks source link

cppcheck warnings 5,6 #257

Closed isildur-g closed 2 months ago

isildur-g commented 2 months ago

mostly false positives.. src/nfa/nfa_api_queue.h:254 [nullPointerRedundantCheck] -> false positive src/nfa/nfa_api_queue.h:255: [nullPointerRedundantCheck] -> false positive src/nfa/nfa_api_queue.h:256: [nullPointerRedundantCheck] -> false positive src/nfa/nfa_api_queue.h:257: [nullPointerRedundantCheck] -> false positive src/nfa/nfa_api_queue.h:258: [nullPointerRedundantCheck] -> false positive

unit/internal/multi_bit.cpp:58: [arithOperationsOnVoidPointer] -> not actually a void pointer, it's declared as unique_ptr<u8[]> unit/internal/multi_bit.cpp:62: [arithOperationsOnVoidPointer] -> not actually a void pointer, it's declared as unique_ptr<u8[]>

unit/internal/multi_bit_compress.cpp:97 [arithOperationsOnVoidPointer] -> not ac tually a void pointer, it's declared as unique_ptr<u8[]> unit/internal/multi_bit_compress.cpp:101 [arithOperationsOnVoidPointer] -> not a ctually a void pointer, it's declared as unique_ptr<u8[]> unit/internal/multi_bit_compress.cpp:119 [arithOperationsOnVoidPointer] -> not a ctually a void pointer, it's declared as unique_ptr<u8[]> unit/internal/multi_bit_compress.cpp:123 [arithOperationsOnVoidPointer] -> not a ctually a void pointer, it's declared as unique_ptr<u8[]>

src/nfa/rdfa.h:81 [uninitMemberVar] -> not a problem, the logic for this is else where. src/util/graph_undirected.h:154 [uninitMemberVar] -> yes, it actually is initia lized in the constructor. src/util/graph_undirected.h:244 [uninitMemberVar] -> yes, it actually is initia lized in the constructor.

src/util/ue2_graph.h:263 [uninitMemberVar] -> it looks like the variable in ques tion is set elsewhere src/util/ue2_graph.h:279 [uninitMemberVar] -> it looks like the variable in ques tion is set elsewhere

benchmarks/benchmarks.hpp:55 [uninitMemberVar] -> yes, it is initialized in the constructor

isildur-g commented 2 months ago

Closes some: #252