search

VectorChi / worldpresidents

A fun open source project for frontend beginners to collaborate.
https://vectorchi.github.io/worldpresidents/
8 stars 10 forks source link

Contributors page #53

Closed VectorChi closed 1 year ago

VectorChi commented 1 year ago

Should include Profile image, name, role, country, portfolio link, Github link

agung2001 commented 1 year ago

hi @VectorChi 👋😄 I would like to take this issue, but I'm gonna need more detail. which contributors page are you referring to?

VectorChi commented 1 year ago

Hi @agung2001 Here, I meant contributors.html

agung2001 commented 1 year ago

alright, if that's ok for you, I would like to create contributors.html page and add it to this repo via pull request (PR). the content of that page will be using the same structure as index.html but with lists of contributors in it. so what do you think?

VectorChi commented 1 year ago

Yeah. That works. Thanks

agung2001 commented 1 year ago

hey @VectorChi 👋😄 I just finished creating the contributors.html page you can review it here :

just let me know if you had any questions, if that looks good you can then merge it 😄👍

VectorChi commented 1 year ago

Nice 👍🏽

VectorChi commented 1 year ago

Great work @agung2001

agung2001 commented 1 year ago

ok, cheerio bro 😄🍻