search

Vectorial1024 / v1024_civilian_fleets

Create civilian fleets to help manage your traders and miners.
https://www.nexusmods.com/x4foundations/mods/335
MIT License
18 stars 10 forks source link

Unsuccessful formation of new mining fleets after recent X4 update #44

Closed Vectorial1024 closed 4 years ago

Vectorial1024 commented 4 years ago

I have heard of v3.20/v3.30 breaking mining fleets some time before, but I wasn't able to properly test it because of the other mods that I have.

Users are now reporting that it indeed broke the mining fleets. Subordinates are getting assigned to "defence" despite picking "mining", causing order sync to fail.

Putting this on hold for now.

Vectorial1024 commented 4 years ago

As I look closer, only new mining fleets seem to be affected. Existing/previous mining fleets seem to continue functioning.

Vectorial1024 commented 4 years ago

Ah, I found it.

The guys at EgoSoft added extra safety checks against accidental impossible assignments (e.g. in vanilla game, miners cannot be assigned to other miners as miners to mine for the commander; they, however, can be assigned to other miners as defenders to protect the commander). This broke our mod.

Supposedly this should break the entire mod. But luckily, as EgoSoft themselves rolled out their ResupplyShip-Trader combo to use the trading assignment, trading fleets managed by this mod are immune to this change.

We will remove that safety check then. A quick modification of existing diff files.

Edit; to be honest, I was not expecting EgoSoft making changes such as that. I first guessed it was something about newly-added mining features from EgoSoft, so I was absolutely confused when the change logs mentioned nothing about mining behaviors (the closest to mining would be to fix a certain ship chassis able to get mining lasers). Turns out EgoSoft was only patching holes in the game, and that hole turned out to be the breathing hole of this mod.