Redemption Update v5+ - Githubissues

Vectorial1024 / v1024_civilian_fleets

Create civilian fleets to help manage your traders and miners.

https://www.nexusmods.com/x4foundations/mods/335

MIT License

18 stars 10 forks source link

Redemption Update v5+ #51

Closed Vectorial1024 closed 3 years ago

Vectorial1024 commented 3 years ago

Correct the mistakes of the v5 update. Restore the pre-CoH legacy methods.

Vectorial1024 commented 3 years ago

There are several parts of the mod that requires restoration from past commits. I think these are:

[x] UI buttons restored
[x] UI buttons actually cause appropriate assignments
[x] Appropriate assignments redirect the code sync logic to the new endpoint, and disable the warning.

Edit: the awkwardness right now is that:

I intended to remove the older "trade"/"mine" assignment and use the "mimic" assignment instead but without prior notice (this is really bad in practice!)
I fixed a few bugs/rewritten a few things/simplified a few things together with this update
People actually want the "trade"/"mine" assignment
Steam does not allow me to roll back to previous version, new version must be "strictly newer"

Vectorial1024 commented 3 years ago

I still believe that we should use Mimic from this point onwards, but I butchered the smooth transition of v5 by abruptly switching over to use Mimic without any prior notice or any convenient note. This is really bad in software engineering. DO NOT try this at home!

Right now I simply add back the legacy Trader/Miner assignment, but there are some extra added features for the smooth transition:

Legacy Civilian Fleets still using Trader/Miner assignment will still sync their code
Newly-assigned civilian fleet members will prompt the entire fleet to become Mimic, and the new logic will take over

With this, the transition to use Mimic is smooth and the user will notice that things are still working like before even when "it is Mimic".

Then changes are not too large that warrants a bump to v6. This will just stay as v5.

Vectorial1024 commented 3 years ago

I keep digging out more and more bugs.

I will write this comment as a section break to separate v5.02 (released) and v5.03 (WIP); some of v5.03 commits are already pushed but are above this comment.

Vectorial1024 commented 3 years ago

Seems no significant reaction until now. Let's wait for a bit longer just to be sure.

Vectorial1024 commented 3 years ago

No significant reaction. Merging.