Request Recheck: traders to trade for aux ships

Vectorial1024 / v1024_civilian_fleets

Create civilian fleets to help manage your traders and miners.

https://www.nexusmods.com/x4foundations/mods/335

MIT License

18 stars 10 forks source link

Request Recheck: traders to trade for aux ships #52

Closed Vectorial1024 closed 2 years ago

Vectorial1024 commented 3 years ago

There is this edge case since X4 v3.0, and I am not sure whether I handled it correctly in the code.

Vectorial1024 commented 3 years ago

I think I found it, the order sync trigger is bugged. Supposedly to check for X4 v3.0 resupplier setups, I should pick the "father" of the trading ship to check if it is a supplier, but then I wrongly picked the "grandfather" of said trader to check. Of course it doesnt work, and with this bug, there is bound to have a lot of "unexplained" occurrence of "failed to order sync" in the debug log due to there being not any "grandfather" in the first place.

Apparently I did not notice this bug while preparing for the X4 4.0 update... that was one sloppy update.

Vectorial1024 commented 3 years ago

OK is this fixed now?

I have no idea?

Well then, I wont close this, but rather elave this hanging.

Vectorial1024 commented 2 years ago

I checked again, and we have this:

At /aiscripts/order.assign.commander.xml:

Fallback Mode is not active anymore
In the Normal Mode, when redirecting from the legacy mode assignments, we check to make sure the commander is not a resupplier

We currently do not make use of the resupplier ship type in the order-sync code. It then follows that this edge case is considered.

Edi: I cannot remember when we transitioned to use Mimicry Extension, but the above text is supposed to be in effect since Mimicry Extension.