Vectorial1024 / v1024_civilian_fleets

Create civilian fleets to help manage your traders and miners.
https://www.nexusmods.com/x4foundations/mods/335
MIT License
18 stars 10 forks source link

Not an issues but a request. Change numbering #69

Open Docwho1983 opened 1 year ago

Docwho1983 commented 1 year ago

Could we add 00 in front of the 1-9 fleets and then 0 infront of the 10-99 fleets?

So that the fleets will line up correctly in the fleet list. Just to make life easier.

Thanks.

Vectorial1024 commented 1 year ago

Hi there!

X4's engine do not have good string support (at least this is my impression) so if we want to do this, we will have to hard-code the logic for 0-9, 10-99, and the remaining (i.e., the default case).

And I think we can do this.

We will have to look at the relevant code:

https://github.com/Vectorial1024/v1024_civilian_fleets/blob/88f18708d5ba68235cd8a60a4163e57da35a2abd/md/civilianfleets_signals.xml#L750C25-L753

And add if-cases to it. This also means we will have to add in extra language strings in the t-folders.

Vectorial1024 commented 1 year ago

In theory, there will be at most around 10-20 civilian fleets in operation at the same time (late game will probably see them converted into station traders for better management), but realistically, fleet numbers will likely reach the 3-digits when fleet leaders start dying to enemy ships in the end-late game.

Some thoughts:

Vectorial1024 commented 1 year ago

This has some interesting implications; if this works in a general way, then #22 will become sensible.