Remove mirror == msg.sender checks for view functions in DN404Fallback. Kudos to BT404.
Clean the upper 96 bits of from and to in _directLogsMalloc. Should not be an issue if from and to are from external function args in transfer, but let's be extra safe.
Make _tokenURI internal. Saves on bytecode. Note that the increase in gas in the benchmark is because the removal of tokenURI from the public function dispatch table moves transfer to the end of a function dispatch node. In practice, the actual gas should go down by a bit.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
[x] Ran forge fmt?
[x] Ran forge snapshot?
[x] Ran forge test?
Pull requests with an incomplete checklist will be thrown out.
Description
_findFirstUnset.mirror == msg.senderchecks for view functions inDN404Fallback. Kudos to BT404.fromandtoin_directLogsMalloc. Should not be an issue iffromandtoare from external function args intransfer, but let's be extra safe._tokenURIinternal. Saves on bytecode. Note that the increase in gas in the benchmark is because the removal oftokenURIfrom the public function dispatch table movestransferto the end of a function dispatch node. In practice, the actual gas should go down by a bit.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.