Vectorized / dn404

Implementation of a co-joined ERC20 and ERC721 pair.
MIT License
476 stars 158 forks source link

✨ Add NFT transfer in DN404 with ERC721 Transfer event #120

Closed DNisch closed 7 months ago

DNisch commented 7 months ago

Description

It would be good if you could transfer NFTs in a contract that extends the DN404 contract. The problem is that the _transferFromNFT function does not emit a Transfer event in the DN404Mirror. The log functions (_directLogsMalloc, ...) are private, so I can't use them for this. I would therefore suggest to add a transferNft function that emits a Transfer event in the DN404Mirror (as done in this PR), or make the log functions internal.

Checklist

Ensure you completed all of the steps below before submitting your pull request: